Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix memory leaks on macOS and memory exposure vulnerability #293

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

appden
Copy link
Contributor

@appden appden commented Aug 1, 2020

This fix memory leaks that were found with the Xcode memory leak tool. This also upgrades bl to fix a remote memory exposure vulnerability: https://snyk.io/vuln/SNYK-JS-BL-608877

@appden
Copy link
Contributor Author

appden commented Aug 31, 2020

@shiftkey Would you mind reviewing this one? Thanks!

@appden appden changed the title Fix memory leaks on macOS Fix memory leaks on macOS and memory exposure vulnerability Aug 31, 2020
@shiftkey
Copy link
Contributor

@appden apologies for the delay - I must have missed this notification.

It looks like bl was updated in #306 which I merged so I'm going to try and rebase this on top of master and review the other changes.

These leaks popped up in the Xcode memory leak tool.
Copy link
Contributor

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough - thanks for the contribution @appden!

@shiftkey shiftkey merged commit a6ee40c into atom:master Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants